search

columbus-elixir / marketing

12 stars 8 forks source link

[WIP] #110 Add base functionality for adding a new meeting #111

Open detri opened 4 years ago

detri commented 4 years ago

Related Issue https://github.com/columbus-elixir/marketing/issues/110

This PR adds a screen for adding a new meeting, as well as a few controller actions to make it possible.

Validation

This is my first Elixir PR! Let me know if anything needs added/changed.

croz1007 commented 4 years ago

@detri Do you have screenshots of this work? Are there tests for the work? What is the URL to make this function? I don't see any updates to the router and I don't see any controls for creating or editing meetings

detri commented 4 years ago

@detri Do you have screenshots of this work? Are there tests for the work? What is the URL to make this function? I don't see any updates to the router and I don't see any controls for creating or editing meetings

I'll add tests, screenshots, and an edit page. I'll also make sure the router is up to date. This is MVP right now based on the issue description, but the validation steps should be working. I can mark it as a WIP until I add all of that stuff - I appreciate all the feedback.

croz1007 commented 4 years ago

@detri Sounds great. Please let me know if you have questions about the issue or have suggestions for how this can be better. Thanks for picking up the issue.

detri commented 4 years ago

I've added tests and create/update/delete ability for meetings. It looks like the "show" page (which has the edit/delete controls) can't currently be accessed without typing in the URL manually (which means knowing the meeting ID). Same for the "new" page, you'd need to type the URL manually. Should we add a "new meeting" button to the top of the "index" page, and "show meeting" buttons on all of the meetings? Or should we create some sort of admin page for meetings separate from the current meeting pages? Let me know what you think.

Once we figure that out I'll add screenshots and then we can fix it up as needed :)

P.S. We use the resources function with the meetings controller in the router, meaning all of the new actions I've added to the meetings controller should already be exposed.