Closed skord closed 12 years ago
+1
I'm gonna work on this next
This also implies that conversations have an order, which currently is the default of the ID. Do we do this as:
Having comment touch
conversation and sort by updated_at makes the most sense to me.
Yeah, we should show the most recently added-to conversation at the top of the index.
Default two field sort. First by sticky/non-sticky, then by updated_at.
I've got this about 90% implemented, working on the last few cukes, will send a PR tonight probably.
Awesome!
Any movement on this @DVG?
Still got one scenario to pass. Got distracted this weekend with my bachelor party. Try and finish up tonight
Well, jeez, I guess that's important enough :)
So I still haven't gotten a chance to finish this up, and wedding stuff has ramped up like whoa, so I don't think I'm going to get to until I get back on the 25th. So I'm gonna go ahead and try to merge upstream tonight, push my changes to my fork and if someone wants to take over they can.
Added in 9585b37
A conversation should be sticky-able, meaning it is at the top of the list of topical conversations.
A conversation should also be lockable, where it is still displayed to users, but is closed for additional commenting.
Of course, these will also require the inverse methods of unsticky and unlock.