columbusrb / conclave

Soon to be the greatest web forum EVER DEVISED.
http://conclaveapp.herokuapp.com/
17 stars 14 forks source link

Conversations should be stickyable and lockable #20

Closed skord closed 12 years ago

skord commented 12 years ago

A conversation should be sticky-able, meaning it is at the top of the list of topical conversations.

A conversation should also be lockable, where it is still displayed to users, but is closed for additional commenting.

Of course, these will also require the inverse methods of unsticky and unlock.

mdarby commented 12 years ago

+1

DVG commented 12 years ago

I'm gonna work on this next

skord commented 12 years ago

This also implies that conversations have an order, which currently is the default of the ID. Do we do this as:

  1. As comments are added to conversations, they move to the top (updated at or acts_as_list)
  2. Conversations are in a fixed order by id/created_at.
  3. Allow users to decide whether they sort by option 1 or option 2.
DVG commented 12 years ago

Having comment touch conversation and sort by updated_at makes the most sense to me.

mdarby commented 12 years ago

Yeah, we should show the most recently added-to conversation at the top of the index.

tllucero commented 12 years ago

Default two field sort. First by sticky/non-sticky, then by updated_at.

DVG commented 12 years ago

I've got this about 90% implemented, working on the last few cukes, will send a PR tonight probably.

mdarby commented 12 years ago

Awesome!

mdarby commented 12 years ago

Any movement on this @DVG?

DVG commented 12 years ago

Still got one scenario to pass. Got distracted this weekend with my bachelor party. Try and finish up tonight

mdarby commented 12 years ago

Well, jeez, I guess that's important enough :)

DVG commented 12 years ago

So I still haven't gotten a chance to finish this up, and wedding stuff has ramped up like whoa, so I don't think I'm going to get to until I get back on the 25th. So I'm gonna go ahead and try to merge upstream tonight, push my changes to my fork and if someone wants to take over they can.

mdarby commented 12 years ago

Added in 9585b37