search

columncolab / EMC2

Earth Model Column Collabratory
BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

FIX: critical subcolumn generator bugs #100

Closed isilber closed 1 year ago

isilber commented 1 year ago
  1. Overlap logic issues in statiform cloud allocation that could have resulted in lack of allocation (e.g., when cl > 0 & ci == 0 and vice versa)
  2. Treatment of strat precip allocation for precip classes with different fractions that could have resulted in a uniform maximum fraction
  3. Possible double allocation to the same subcolumn when precip classes have different fractions
  4. q allocation issue for cl in microphyisics approach, which could often resulted in a cl-containing subcolumn having a q value of 0 kg/kg
isilber commented 1 year ago

@rcjackson I think that those issues are now fixed (tested it on multiple files and cases). However, I would appreciate having a second pair of eyes looking at my edits to the code.