search

columncolab / EMC2

Earth Model Column Collabratory
BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

ADD: NUWRF fall speed parameterization and fixes to WRF data loading #104

Closed rcjackson closed 1 year ago

rcjackson commented 1 year ago

I've added the fall speed assumptions from NUWRF into EMC^2 and also fixed an issue in the WRF data loader where EMC^2 was not generating radar/lidar observables outside of cloud but in precipitation from WRF files. I have also cleaned up some of the syntax of the code inside the subcolumn generator.

rcjackson commented 1 year ago

Fails in tests are due to ACT changing how it represents the dataset inside the Display object. Changed _obj to _ds to match ACT. I fixed that issue as well on top of adding in your suggestions @isilber.