search

columncolab / EMC2

Earth Model Column Collabratory
BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

Bug fixes in hydrometeor assignment #115

Closed mengz1993 closed 3 months ago

mengz1993 commented 3 months ago

Three bugs are fixed in subcolumn distribution and inconsistent hydrometeor fraction assignment.

  1. In function _set_precip_sub_colfrac (subcolumn.py) that computes the subcolumn distribution of precipitation hydrometeors, EMC2 incorrectly passes the model convective hydrometeor mass to stratiform precipitation hydrometeors.
  2. In _calc_lidar_micro (lidarmoments.py) and _calc_radar_micro (radarmoments.py), the use of hydrometeor fraction is inconsistent. Based on Israel's comment, this should not have a significant impact, as it was corrected/overridden at some point in the code.
  3. In function _calc_mulambda (psd.py), the hydrometeor fraction uses the value without being distributed in subcolumns but the hydrometeor number and mass use values after being distributed in subcolumns.
mengz1993 commented 3 months ago

@isilber Thank you for reviewing the code. The code has been corrected following your comments. Please let me know if you have any additional comments. Thanks!