search

columncolab / EMC2

Earth Model Column Collabratory
BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

Bugs in LDR and reflectivity calculation #19

Closed rcjackson closed 4 years ago

rcjackson commented 4 years ago

@isilber has pointed out a couple of issues with the LDR and Z calculations. I'll focus my efforts on this next week.

Hi Bobby,

I've been playing a bit with the EMC2 module methods as I wanted to start generating plots for the manuscript. Two errors that I already noticed:

  1. The LDR profile shows values that do not make sense because they are lower than the lowest LDR per hyd. In addition, they seem to be the highest actually within the liquid layer, where they should be the lowest. Do you have an idea of where in the code should I start searching for the error (the lines of the script I used to generate plot are shown below)? HSRL = emc2.core.instruments.HSRL() my_model2 = emc2.simulator.main.make_simulated_data(my_model, HSRL, 100)

fig, ax = plt.subplots() Time_2_plot = 17 x_variable = np.squeeze(np.nanmean(my_model2.ds.sub_col_LDR_strat[:,Time_2_plot,:], axis=0)) x_err = np.squeeze(np.nanstd(my_model2.ds.sub_col_LDR_strat[:,Time_2_plot,:], ddof=0, axis=0)) ax.plot(x_variable, my_model2.ds.z[Time_2_plot,:]) ax.fill_betweenx(my_model2.ds.z[Time_2_plot,:], x_variable - x_err, x_variable + x_err, alpha=0.5, color='deepskyblue')

plt.xscale('log')

plt.xlim(1e-8, 2e-2)

plt.xlim(0.0, 0.1) plt.ylim(0, 2e3) plt.show()

  1. KAZR output also generates weird output (Ze is way too low and occasionally contain nan values - if you recall, you showed a similar output in our meeting on Monday). The calculation in the code seems legit at a glimpse, so I suspect we would have to dig deeper here.

  2. Ze_conv does not have the subcolumn dimension.

rcjackson commented 4 years ago

This issue was fixed with the latest PRs. Closing.