Significant EMC2 update: modify the simulator concept to allow three approaches (microphysics logic/radiation logic/empirical)

columncolab / EMC2

Earth Model Column Collabratory

BSD 3-Clause "New" or "Revised" License

10 stars 7 forks source link

Significant EMC2 update: modify the simulator concept to allow three approaches (microphysics logic/radiation logic/empirical) #38

Closed isilber closed 3 years ago

isilber commented 3 years ago

Update metadata and modify certain fields and name lists for consistency all across. Numerous bug and calculation error fixes. Update README file. This will be the final version presented in the EMC2 manuscript (minor updates are still possible).

rcjackson commented 3 years ago

I've made a few changes to the tests to account for your new features as well as updates to the plotters that accounted for changes in matplotlib that broke the tests. However, your file that you are using for test plotting is missing the phase_mask_KAZR_sounding_all_hyd variable and it seems like the test needs it. Could you include this in your test netCDF file?

isilber commented 3 years ago

I've made a few changes to the tests to account for your new features as well as updates to the plotters that accounted for changes in matplotlib that broke the tests. However, your file that you are using for test plotting is missing the phase_mask_KAZR_sounding_all_hyd variable and it seems like the test needs it. Could you include this in your test netCDF file?

Done!