search

columncolab / EMC2

Earth Model Column Collabratory
BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

Instrument sub-classes and scattering LUT updates #44

Closed isilber closed 3 years ago

rcjackson commented 3 years ago

I noticed that your notebook uses nbformat 4.0. I think you need to upgrade your nbformat on your PC to 5.1. I suspect there is a conflict here with the version sphinx is using and the one you have on your pc.

isilber commented 3 years ago

That is interesting because I do use 5.1.2. Don't know why the notebook version was set to 4.

rcjackson commented 3 years ago

Good catch on the typo. It was causing the pep8 checker to fail and I was wondering why.

isilber commented 3 years ago

Don't know if related, but the demo notebook is no longer seen in the documentation.

rcjackson commented 3 years ago

/home/travis/build/columncolab/EMC2/doc/source/index.rst:32: WARNING: toctree contains reference to document 'EMC2example' that doesn't have a title: no link will be generated Sphinx seems to be complaining about there being no title on the example notebook.

Bobby

From: isilber @.> Sent: Friday, May 21, 2021 11:22 AM To: columncolab/EMC2 @.> Cc: Jackson, Robert @.>; State change @.> Subject: Re: [columncolab/EMC2] Instrument sub-classes and scattering LUT updates (#44)

Don't know if related, but the demo notebook is no longer seen in the documentation.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/columncolab/EMC2/pull/44#issuecomment-846079286, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFIQA5A67DCSGHPPNKIHXVTTO2CD5ANCNFSM45HQEPAQ.

isilber commented 3 years ago

That's weird. I have nbformat v. 5.1.2 but I cannot load the notebook with the current settings unless I change the nbformat version in the notebook back to 4.4. I note that previously the nbformat version did not make any issues in building the docs (still working fine when built locally).