search

colymba / GridFieldBulkEditingTools

SilverStripe GridField Components set for bulk upload and bulk record edit, unlink & delete :package::boom:
BSD 3-Clause "New" or "Revised" License
88 stars 81 forks source link

Select all checkbox doesn't have a visuable label anymore #180

Open raissanorth opened 6 years ago

raissanorth commented 6 years ago

2c40a16198aea55fc2c34835fdcddef0d4ead058 removed the title for the select all checkbox, to be precise:

 <% _t('GRIDFIELD_BULK_MANAGER.SELECT_ALL_LABEL', $Select.Label) %>

This causes the checkbox to look out of place - or a misrendered checkbox -, see e.g. the screenshot from the Comments tab:

image

While it is not hard to add this back into the label, the spacing causes some issues since 'Select all' would wrap over two lines...

image

Tried fixing this with white-space: no-wrap which caused the text to be disaligned...

image

Sorry don't have more time to look into this today, but wanted to capture this somehow.

colymba commented 6 years ago

Yeah I know what you mean... All would probably be solved if we have the checkboxes on the left of the gridfield and the select-all box in the gridfield header.

robbieaverill commented 6 years ago

+1 for moving it to the left. I think in that case not having a label would be fine, because most web UIs that have a select all feature would look like that anyway so people would usually understand what it does. We'd still need to provide an aria label though for screen readers.