colymba / GridFieldBulkEditingTools

SilverStripe GridField Components set for bulk upload and bulk record edit, unlink & delete :package::boom:
BSD 3-Clause "New" or "Revised" License
88 stars 81 forks source link

Selecting from assets does not work. #194

Open martinviolet88 opened 4 years ago

martinviolet88 commented 4 years ago

Selecting images from the image libary does not work. After selecting they do appear under the bulk uploader but not in the grifield. After doing a hard ctrl shift r it does seem to work. So my guess it's a caching error? No error's found.

screencapture-localhost-theaterv2-admin-Artiesten-Producent-ArtiestPage-EditForm-field-ArtiestPage-item-35157-edit-2020-02-10-18_10_11 (1)

guyvanbael commented 3 years ago

any update on this?

martinviolet88 commented 3 years ago

@guyvanbael Nope, having the same problem?

kinglozzer commented 3 years ago

I think this PR might also fix this issue: https://github.com/colymba/GridFieldBulkEditingTools/pull/205. Or possibly https://github.com/colymba/GridFieldBulkEditingTools/pull/206

guyvanbael commented 3 years ago

@kinglozzer just used dev-master in my latest project, but issue still occuring

EdvJa commented 3 years ago

same issue here, after some time investigating the problem I didn't manage to find error or something... ended up here :)

acndr commented 3 years ago

Did this ever get resolved? We've just discovered the same problem, also using dev-master. However for us it seems to only be a problem about 50% of the time.

acndr commented 3 years ago

After some digging I think I've found the problem to this. In the uploader.js file the bulkUploadFieldReducer reducer is wrapped with a JS DOMContentLoaded. However this file is only requested when a SiteTree page is loaded up in the CMS, meaning the DOM is already loaded and this reducer never gets added. This is only a problem when you load the CMS via /admin then browse to a page to edit - if you refresh on a SiteTree page or route straight to a page (e.g. /admin/pages/edit/show/1) then the correct events are fired and everything works.

I don't know enough about the admin javascript lifecycle to confidently create a PR for this, but perhaps someone else can use this info for a fix?

@kinglozzer

martinviolet88 commented 3 years ago

Would be awesome if we can get it fixxed;), i'm so annoyed by it that im willing to pay for someone to fix it haha..

mikey-harveycameron commented 1 year ago

need this fixed... but not the jansneeuw namespace changes