search

colymba / GridFieldGalleryTheme

Gallery view styling and functionalities of SS3 GridField
15 stars 10 forks source link

Delete/unlink shoud have a confirmation #14

Closed RoyalPulp closed 10 years ago

RoyalPulp commented 10 years ago

As I tried to reproduce the ToolTip Issue on Firefox, I accidentally removed an Image when I clicked on the "delete" Icon within the Thumbnail..

Too easy to detach or delete an Image!! Please add a "confirm" question or an "undo"

colymba commented 10 years ago

I get a confirm dialog when clicking the delete icon, not the unlink though. But in any case, this is a framework issue, not related to this module, since those buttons are from GridFieldDeleteAction and GridFieldEditButton....

colymba commented 10 years ago

There was an issue here https://github.com/silverstripe/silverstripe-framework/pull/2502 but was fixed a while back. Does this still happen without the GridFieldGalleryTheme module?

RoyalPulp commented 10 years ago

Yes, I just tried it without your Modult. Delets the Item without confirmation

colymba commented 10 years ago

Closing since unrelated, feel free to re-open if not...

Check that you have that patch 2502 mentioned above in your framework dir... otherwise it could come from another module overriding some entwine methods....