colymba / GridFieldGalleryTheme

Gallery view styling and functionalities of SS3 GridField
15 stars 10 forks source link

Small improvements to Edit/Delete buttons #3

Closed steffen-maass closed 11 years ago

steffen-maass commented 11 years ago

I improved two aspects of the col-buttons:

I'd also like to thank colymba for publishing his GridField-extensions, managing images is so much easier and better now!

Best regards, s-m

colymba commented 11 years ago

:+1: for https://github.com/s-m/GridFieldGalleryTheme/commit/4953621157281ef8bceb42b81f7d0c407d11dfbd hiding those col-buttons make things a lot better for drag-n-drop!

Not sure about the 90% opacity though... I could see the point but in some cases, depending on the image in the background, it makes thing a bit hard to see.

This make me think, having the option to pass a custom stylesheet to override some default might be of interest?

steffen-maass commented 11 years ago

Hi,

just tried it and it works with a sass-style selector, commit is attached...

steffen-maass commented 11 years ago

I added the opacity-thing because of a customer request, after a bit of testing the 90%-opacity gave the best results in terms of still recognizing the image as well as the edit/delete buttons. Another option would be an overlay which just contains the buttons and a bit of white around them, but still lets the user see the image he would be editing/deleting...

Greetings, s-m

steffen-maass commented 11 years ago

I'm splitting this into two seperate pull requests, i'm therefore closing this pull request for now...

Greetings, s-m