search

colymba / GridFieldGalleryTheme

Gallery view styling and functionalities of SS3 GridField
15 stars 10 forks source link

FEATURE: Allow some customisation of thumbnail #8

Open mellm0 opened 11 years ago

mellm0 commented 11 years ago

I have not edited the CSS yet, so it won't fit well for items that use different width and height, but you can now use PaddedImage etc.

I didn't have much luck with my quick look at the CSS...

I added a second commit, using getFormattedImage as well, since sometimes only a generateImageFormat method is provided (because that's how it is in the docs)

colymba commented 11 years ago

This looks pretty good. Did some test and works fine as far as I can see.

You're right, the CSS needs to be updated since we are allowing for custom thumbnail size. Although with a few test, changing the CSS file will most likely not be enough. It will probably need to be injected as inline style in the HTML and that might require updating getColumnsHandled.... Would be good to have this sorted before merging... I'll have to dig around...

purplespider commented 10 years ago

Would love to get this finished and included if possible, as working on a project that I'm using FocusPoint in (https://github.com/jonom/silverstripe-focuspoint) which would go very nicely with this update.