search

colymba / silverstripe-restfulapi

SilverStripe RESTful API with a default JSON serializer.
BSD 3-Clause "New" or "Revised" License
64 stars 34 forks source link

Silverstripe 4 support #92

Closed adrexia closed 5 years ago

adrexia commented 6 years ago

Updates to make this module compatible with silverstripe 4

colymba commented 6 years ago

Cool, thanks for the hard work! Since we are changing class name and have the namespace, I would be inclined to remove RESTfulAPI out of all class names, since it already is in the namespace. That would make everything even neater... what do you think?

robingram commented 6 years ago

@adrexia We'd be keen to see this change incorporated into a release but I agree with @colymba that the namespace makes the RESTfulAPI part of the class name redundant. There is a possibility that I might be able to help out with that if you're short of time to make the changes.

I'd also like to reiterate, thanks for your work in making this update. :)

adrexia commented 6 years ago

@robingram if you could, that would be great! We're a bit snowed under right now, so haven't had time to look at this since it was first done.

robingram commented 6 years ago

@adrexia I'm in the process but I came across a number of issues. The main problem was that it couldn't work for namespaced models. I managed to get it operational for a basic unauthenticated use case last week but I want to make sure that the test suite is green.

I hope to get it done this week but realistically I only have Thursday to work on it.

robingram commented 5 years ago

Hi @colymba, @adrexia. I'm finally close to having this ready to go. I just want to review the history and probably squash a few commits because currently there are 33. :)

How would you prefer me to handle the PR? I guess there are a couple of options. I could create a PR to dnadesign that would then update this or create a whole new PR here to replace this one.

I'm leaning towards the latter because there are a couple of changes that I think it would be good for @colymba to look through and that might just cause problems for DNA if they are already in their fork.

adrexia commented 5 years ago

@robingram do what's easiest for you, we don't mind too much. :)

colymba commented 5 years ago

@robingram on dnadesign is fine. Thx!

colymba commented 5 years ago

worked continued here https://github.com/colymba/silverstripe-restfulapi/pull/93