Closed ProGM closed 6 years ago
Great catches, @ProGM! thanks a lot for taking your time to submit this PR.
Which operating system are you using? I've tested c3addon
only on Mac.
Cheers!
Published new version here: https://www.construct.net/br/make-games/addons/111/colyseus-multiplayer/0-9-4
@endel 👍
I have a Mac, too... Who knows!
Hi there, This PR fixes a few bugs I found with this plugin.
operation
parameter returned the index of the dropdown instead of the value. Maybe is it some kind of breaking change in the editor?this.matcherPlaceholders[":*"]
was not defined. I assumed it was meant to beself.room.matcherPlaceholders[":*"]
Colyseus.State()
always crashed, because it was accessing tothis.room.data
instead ofthis.room.state
try {...} catch {...}
to thegetDeepVariable
helper function, to handle wrong paths gracefully.I hope you'll appreciate ;)
As a side note: The build command
c3addon pack --root plugin
is kinda broken. It generates a package that is recognized as invalid from Construct. To make it work, I had to unzip it and zip it again the files to create a valid one.