search

colyseus / colyseus-examples

Examples for learning how Colyseus works
https://examples.colyseus.dev/
MIT License
178 stars 90 forks source link

Live demo and the examples are not working #14

Closed idtoufik closed 5 years ago

idtoufik commented 5 years ago

Hi, I have tried the instructions that I have found on the readme to set up the project but it doesn't seem to work I'm getting connection refused error when I access http://localhost:2657/, also I have tried the heroku live demo I think that it is also not working I'm getting a lot of errors in the browser console. My node server version is 10.15.1 Thanks

Tobi4s1337 commented 5 years ago

Hey @idtoufik , please try to open the following link in your browser after you started your local server: http://localhost:2567/ Then it should be working =) (Seems like there is a typo somewhere)

idtoufik commented 5 years ago

Don't know why but it works now, I have followed the same steps before submitting this issue. Thank you.

IanMayo commented 5 years ago

@idtoufik - I'm pretty sure you mis-typed the port number, the 6 and 5 are reversed in your comment.

Here's what I see: image

idtoufik commented 5 years ago

thank you for your remark. I was sure that I didn't make any port number error because I have clicked on the link that I have found in the readme file, it appears that the link present in the readme "http://localhost:2567" redirects to "http://localhost:2657" can you please fix this. Thanks

IanMayo commented 5 years ago

Hey - that was cryptic - well spotted.

How about having a go at fixing it. Just click on the "Edit" button at the top-right of the README.md file: image

IanMayo commented 5 years ago

Here is where the problem arose, it was an edit made 30 minutes ago: image

https://github.com/colyseus/colyseus-examples/commit/9d6be7bd05470a8064cc740cf83d01fd9283ca38#diff-04c6e90faac2675aa89e2176d2eec7d8

idtoufik commented 5 years ago

Ok thanks, I didn't have the rights otherwise I did it my self.

IanMayo commented 5 years ago

@idtoufik = you don't need write access to this repo to do it, the change happens in a forked repo.

I just made the change - it took seconds: https://github.com/colyseus/colyseus-examples/pull/15

Tobi4s1337 commented 5 years ago

@idtoufik = you don't need write access to this repo to do it, the change happens in a forked repo.

I just made the change - it took seconds:

15

Oh that is definitely good to know. (Also did not know about this before)

idtoufik commented 5 years ago

sorry I didn't see your comments.