Improve use of generics and privacy levels in `ArraySchema` and `MapSchema`

colyseus / colyseus-unity-sdk

⚔ Colyseus Multiplayer SDK for Unity

https://docs.colyseus.io/getting-started/unity-sdk/

MIT License

371 stars 102 forks source link

Improve use of generics and privacy levels in `ArraySchema` and `MapSchema` #137

Open rnd256 opened 3 years ago

rnd256 commented 3 years ago

ArraySchema's method signatures for GetItems(), GetByIndex(index), ContainsKey(key), GetTypeDefaultValue(), SetItems(), and InvokeOn{Add,Change,Remove}() should use type T.
The Items member should probably be private.
It seems like there are some methods that manage internal details which shouldn't be public (eg. GetIndex(index) without the By in the name, and anything that has dynamicIndex in its signature).
Similar improvements can be made to MapSchema.

endel commented 3 years ago

Thanks for the feedback @rnd256, I agree completely, all these methods should be for internal usage only and not exposed. I hope we can tackle this sooner or later.

rnd256 commented 3 years ago

I think the methods in the first bullet point I mention should remain public, but agreed on making the other ones private.