Open rnd256 opened 3 years ago
Thanks for the feedback @rnd256, I agree completely, all these methods should be for internal usage only and not exposed. I hope we can tackle this sooner or later.
I think the methods in the first bullet point I mention should remain public, but agreed on making the other ones private.
ArraySchema
's method signatures forGetItems()
,GetByIndex(index)
,ContainsKey(key)
,GetTypeDefaultValue()
,SetItems()
, andInvokeOn{Add,Change,Remove}()
should use typeT
.Items
member should probably be private.GetIndex(index)
without theBy
in the name, and anything that hasdynamicIndex
in its signature).MapSchema
.