colyseus / colyseus-unity-sdk

⚔ Colyseus Multiplayer SDK for Unity
https://docs.colyseus.io/getting-started/unity-sdk/
MIT License
371 stars 102 forks source link

Fix 148 join or create #149

Closed mitchLucid closed 3 years ago

mitchLucid commented 3 years ago

Removed the implied expectation that users would provide an onAddRoom callback function to the ColyseusClient. The client itself now performs the .Connect() call on the room, at the same time where it previously was attempting to invoke the onAddRoom callback if it had been provided. Also restructured the JoinOrCreate function to match the Join and Create functions and added a way to trigger it from within the example Lobby

Fixes Issue 148

tonygiang commented 3 years ago

Hey, I just pulled this branch to test out, it's still not entirely fixed. With this branch, the server has received the Join signal and proceeded with the client joining, but the JoinOrCreate task still runs indefinitely with the status WaitingForActivation.