search

colyseus / colyseus-unity-sdk

⚔ Colyseus Multiplayer SDK for Unity
https://docs.colyseus.io/getting-started/unity-sdk/
MIT License
371 stars 100 forks source link

Make OnJoin private #216

Open endel opened 1 year ago

endel commented 1 year ago

The room's OnJoin event is internal and should not be exposed publicly: https://github.com/colyseus/colyseus-unity-sdk/blob/47ff44abc9448e3650b9c973f69668945ba7adcb/Assets/Colyseus/Runtime/Colyseus/Room/ColyseusRoom.cs#L193-L196

This causes confusion to some users starting out as OnJoin is not necessary to detect joins since version 0.14. This event is leftover from previous iterations and must be refactored.