search

colyseus / proxy

🔀⚔ Proxy and Service Discovery for Colyseus 0.10 ~ 0.14 (Not recommended on 0.15+)
https://docs.colyseus.io/scalability/
MIT License
37 stars 25 forks source link

Optionally enable health check with `HEALTH_CHECK_PATH` env var #26

Closed epiphone closed 1 year ago

epiphone commented 2 years ago

Addresses https://github.com/colyseus/proxy/issues/17.

pnutmath commented 2 years ago

Kubernetes have multiple health-check endpoints for different purpose https://kubernetes.io/docs/reference/using-api/health-checks/

epiphone commented 2 years ago

@pnutmath I recommend opening another PR for any extended features.

pnutmath commented 2 years ago

@epiphone We can add health check at colyseus server level... which will proxy through colyseus proxy.. No need of separate health check here

epiphone commented 2 years ago

I think a separate health check is useful: Proxy and Server processes can run on separate instances and may be independently scaled.

endel commented 1 year ago

Thank you for the PR @epiphone 🙏 , just merged https://github.com/colyseus/proxy/pull/35 that contains your changes + other feedback. Cheers!