[Colyseus-422] dropped arrayBuffer when length is 0

colyseus / uWebSockets-express

Express API compatibility layer for uWebSockets.js

https://npmjs.com/package/uwebsockets-express

MIT License

56 stars 13 forks source link

[Colyseus-422] dropped arrayBuffer when length is 0 #10

Closed Vidski closed 3 years ago

Vidski commented 3 years ago

There is no need to concat when body is 0, also fixes a rare case where body is dropped when isLast=false and arrayBuffer.length 0.

See: https://github.com/colyseus/colyseus/issues/422

endel commented 3 years ago

Thank you so much for the PR @Vidski!

I had your fix applied locally but I'm still investigating the aborting issue you reported yesterday! As soon as that one is fixed I'm going to publish a new version! Thank you so much for collaborating on this