Closed lefou closed 4 months ago
The BSP server tests seem to not work for various Scala versions.
amm[2.13.2].test.testCached 12 tests failed:
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.router imports
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file and compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.single comment with no line feed
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.build changed notification
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.don't delete directories in target
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.dash in name
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.semanticdb
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.caching
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.cache clean-up
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.simple
amm[2.13.3].test.testCached 12 tests failed:
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.dash in name
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.router imports
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.caching
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.single comment with no line feed
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.build changed notification
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.don't delete directories in target
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.cache clean-up
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file and compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.simple
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.semanticdb
amm[2.13.4].test.testCached 12 tests failed:
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.dash in name
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.router imports
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.build changed notification
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file and compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.single comment with no line feed
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.don't delete directories in target
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.caching
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.cache clean-up
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.simple
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.semanticdb
amm[2.13.5].test.testCached 12 tests failed:
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.simple
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.dash in name
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.router imports
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.don't delete directories in target
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.single comment with no line feed
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file and compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.build changed notification
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.caching
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.semanticdb
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.cache clean-up
amm[2.13.6].test.testCached 12 tests failed:
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.single comment with no line feed
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.dash in name
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.build changed notification
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.router imports
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.simple
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file and compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.don't delete directories in target
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.caching
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.cache clean-up
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.semanticdb
amm[2.13.7].test.testCached 12 tests failed:
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.dash in name
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.router imports
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.don't delete directories in target
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.single comment with no line feed
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.simple
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.caching
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.cache clean-up
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file and compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.semanticdb
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.build changed notification
amm[2.13.8].test.testCached 12 tests failed:
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.simple
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.dash in name
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.single comment with no line feed
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file and compilation
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.cache clean-up
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.don't delete directories in target
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.build changed notification
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.router imports
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.errored.import file
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.semanticdb
ammonite.interp.script.AmmoniteBuildServerTests ammonite.interp.script.AmmoniteBuildServerTests.caching
Also use
testCached
in theunitTest
andintegrationTest
commands to avoid repeating tests.I needed to make the following adaptions:
AmmoniteBuildServerTests
. I think those never run successfully, but we never ran then on CI, so we didn't catch those issues.BasisTests
integration test. I seems to always fail when run on any Scala 3 version we support.Due to running much more tests (same tests on more Scala versions), the test suite now takes longer. Since Ammonite isn't seeing many contributions nowadays and most contributions are maintenance tasks, having a better coverage is a bonus worth the somewhat longer waiting time. I expect the time to increase once we add more Scala patch version to a supported line. To speed things up, we have the option to scale out by splitting up the Scala versions in test matrix.