Closed jodersky closed 4 years ago
The latest commit fixes the ambiguity error. It unfortunately requires a change to upickle, as shown here.
Both upickle and requests are on maven now, so it should be possible to test this against the CI.
Perfect, thanks for your help @anatoliykmetyuk. I noticed that some test now fails. I'll check what's up
@lihaoyi, @anatoliykmetyuk, the build is green! Let me know what you think
@jodersky I haven't looked at this in detail, but if all the tests pass I say ship it
:pray: thanks
Note: ~this PR is still WIP~, as some items remain to be done:
seqify
in the dotty versionOther items that can be tackled after this is merged:
@doc
annotation handling in the Dotty macroswithDottyCompat
override from the dependencies~@lihaoyi and @anatoliykmetyuk feel free to give this a preliminary review if you'd like. I'll remove the WIP label once the first two items are fixed.~ The PR is ready for review now. ~Before CI can correctly test this however, scala-requests (https://github.com/lihaoyi/requests-scala/pull/68) and upickle (https://github.com/lihaoyi/upickle/pull/322) must be published for Dotty.~