com-lihaoyi / cask

Cask: a Scala HTTP micro-framework. Cask makes it easy to set up a website, backend server, or REST API using Scala
https://com-lihaoyi.github.io/cask/
Other
534 stars 57 forks source link

Dotty port #35

Closed jodersky closed 4 years ago

jodersky commented 4 years ago

Note: ~this PR is still WIP~, as some items remain to be done:

Other items that can be tackled after this is merged:


~@lihaoyi and @anatoliykmetyuk feel free to give this a preliminary review if you'd like. I'll remove the WIP label once the first two items are fixed.~ The PR is ready for review now. ~Before CI can correctly test this however, scala-requests (https://github.com/lihaoyi/requests-scala/pull/68) and upickle (https://github.com/lihaoyi/upickle/pull/322) must be published for Dotty.~

jodersky commented 4 years ago

The latest commit fixes the ambiguity error. It unfortunately requires a change to upickle, as shown here.

anatoliykmetyuk commented 4 years ago

Both upickle and requests are on maven now, so it should be possible to test this against the CI.

jodersky commented 4 years ago

Perfect, thanks for your help @anatoliykmetyuk. I noticed that some test now fails. I'll check what's up

jodersky commented 4 years ago

@lihaoyi, @anatoliykmetyuk, the build is green! Let me know what you think

lihaoyi commented 4 years ago

@jodersky I haven't looked at this in detail, but if all the tests pass I say ship it

jodersky commented 4 years ago

:pray: thanks