Case-insensitive comparison of the "Upgrade" request header

com-lihaoyi / cask

Cask: a Scala HTTP micro-framework. Cask makes it easy to set up a website, backend server, or REST API using Scala

https://com-lihaoyi.github.io/cask/

Other

527 stars 55 forks source link

Case-insensitive comparison of the "Upgrade" request header #78

Closed rom9 closed 1 year ago

rom9 commented 1 year ago

This PR modifies the "Upgrade" header check in DefaultHandler.handleRequest by using a case-insensitive comparison, as per the WebSocket RFC. Sorry for the Yoda condition... it seems that Undertow's HeaderMap.getFirst() can return null.

Fixes #77

jodersky commented 1 year ago

sounds good to me

jodersky commented 1 year ago

thanks!