search

com-lihaoyi / fastparse

Writing Fast Parsers Fast in Scala
https://com-lihaoyi.github.io/fastparse
MIT License
1.09k stars 164 forks source link

Scala 3 preparation #266

Closed ajrnz closed 1 year ago

ajrnz commented 1 year ago

This PR build on 2 previous PRs for scala 3 support

cssparse and pythonparse now compile and pass tests

fastparse still has some test failures

scalaparse has an issue with a macro

davidrwood commented 1 year ago

Is this essentially competing with https://github.com/com-lihaoyi/fastparse/pull/267 ?

kyri-petrou commented 1 year ago

Hi there 👋 I'm one of the contributors of Caliban, and I've been occasionally checking the status of the Scala 3 release of fastparse. Caliban offers supports Scala 2.12, 2.13 and 3. The Scala 2.x versions use fastparse to parse the GraphQL queries and cats-parse for Scala 3 until fastparse becomes available for Scala 3 as well.

I wanted to mention that once you're at a stage with this PR that you're confident in (or have a snapshot release), I'd be happy to test the Scala 3 version of fastparse in Caliban. Since we already have the Scala 2 code, unit tests and benchmarks (for the graphql query parsing), it should be relatively low effort to implement and test

davidrwood commented 1 year ago

@ajrnz Just wondering if you've got a chance to get this wrapped up? It seems like it's very close...

lihaoyi commented 1 year ago

superseded by https://github.com/com-lihaoyi/fastparse/pull/271