search

com-lihaoyi / mill

Mill is a fast JVM build tool that supports Java and Scala. 2-3x faster than Gradle and 5-10x faster than Maven for common workflows, Mill aims to make your project’s build process performant, maintainable, and flexible
https://mill-build.org/
MIT License
2.04k stars 331 forks source link

Migrate `build.sc` to Scala 3 #3152

Open lihaoyi opened 4 months ago

lihaoyi commented 4 months ago

The goal of this ticket is to move Mill from Scala 2.13 to Scala 3.

Most of Mill's code should be easily portable with minimal changes (e.g. syntax tweaks), but there are three major areas which may require more work:

  1. The import $ivy parser is currently using FastParse's ScalaParse, and would need to be moved over to use a Scala 3 compatible parser similar to what Ammonite does

  2. The compiler plugin for auto-override would need to be migrated over

  3. The various macros like Caller, Task, and Applicative would need to be ported over

  4. The CodeSig analyzer used for fine grained invalidation on build.sc code changes may need to be ported over if Scala 3 generates very different bytecode (not sure, seems unlikely?)

  5. Any older dependencies that only support Scala 2 may need to be updated or replaced

The acceptance criteria is A PR that passes all existing tests on Scala 3, and either modify some existing tests to exercise Scala 3 language features, or add new tests to do so. We may not merge the PR immediately, but having the PR open with all tests passing should be enough for us to integrate the Scala 3 support and at our leisure. This would be a breaking change and would need a version bump, with associated downstream inconvenience

lihaoyi commented 4 months ago

Some prior art, an attempt to move the Applicative macro to Scala 3: https://github.com/Iltotore/mill-scala-3

Quafadas commented 4 months ago

I have a personal interest / curiosity in learning about mills internals, and support here could be a good way to do it. I'm realistic that I would fail alone through constraints on both time and skill :-).

I would be happy to offer support, or bite off a little chunk on behalf of someone running point though. I don't have any interest in the bounty. I'm knocking around here or discord if anyone would imagine delegating a little chunk.

Fiend-Star-666 commented 2 months ago

Hi @lefou , is this task still up for grabs?

lihaoyi commented 2 months ago

Yes

Fiend-Star-666 commented 2 months ago

Thanks for confirming, don't assign this to me for now. I'll try to make this change, if i see some success, would update on this thread asap.

bishabosha commented 2 months ago

I am also working on this Edit: progress in PR https://github.com/com-lihaoyi/mill/pull/3369

asarkar commented 1 month ago

I came across this ticket after unsuccessfully attempting to use Scala 3 optional braces syntax in the build.sc. It'll be very helpful to note in the documentation that even if the project uses Scala 3 (which I'm), build.sc must be written using Scala 2 syntax. Tools like Gradle publish a compatibility matrix for each version release, but unless I'm wrong, mill isn't doing that yet, so, it's not at all clear what Scala version(s) is supported by the build.sc.

lihaoyi commented 4 weeks ago

taking down the bounty since @bishabosha is working on this

asarkar commented 4 weeks ago

@lihaoyi Would you offer any migration tools for automatic rewriting, similar to what the compiler does when a source argument is passed?