com-lihaoyi / mill

Your shiny new Java/Scala build tool!
https://mill-build.com/
MIT License
1.99k stars 303 forks source link

Fix timestamp attribute in junit xml report #3172

Closed romain-gilles-ultra closed 1 month ago

romain-gilles-ultra commented 1 month ago

There is a bug in the way the testsuite element is generated.

Actual

    <testsuite name="MyTest" tests="4" failures="0" errors="0" skipped="0"
               time="0.724">
        timestamp=2024-05-21T18:57:25
        ...
    </testsuite>

Expected

    <testsuite name="MyTest" tests="4" failures="0" errors="0" skipped="0"
               time="0.724" timestamp="2024-05-21T18:57:25">
        ...
    </testsuite>

The timestamp attribute in not an attribute...

lefou commented 1 month ago

It would be nice to have some unit test that covers the generated xml document.

romain-gilles-ultra commented 1 month ago

Hi @lefou It's fun you were talking about unit test. I was working on it So yes I will add unit test in another PR.