Closed lefou closed 1 month ago
The test also fails with Mill 0.11.7-50-9a734a
, so there seems to be another issue than I thought. I will try to narrow it down further...
So, the assembly test fails when we bump the build tool Mill from version 0.11.7-17-17dea9
to 0.11.7-29-f2e220
.
My recent bisection shows 824f9 passes tests (https://github.com/com-lihaoyi/mill/pull/3247), so that narrows things down a bit
The only recent changes to Assembly.scala
are https://github.com/com-lihaoyi/mill/commits/main/scalalib/src/mill/scalalib/Assembly.scala, I wonder if it's one of those
Eh not sure why https://github.com/com-lihaoyi/mill/pull/3253 failed while https://github.com/com-lihaoyi/mill/pull/3252 passed while trying to update Mill to an artifact built on the same commit. Something funny is going on
So, I tried to restart the build multiple times but it seems the failure isn't just flakiness but something else I still don't understand.
Looks like the produced assembly isn't executable.
The bumped Mill version (the essence of this PR) contains also a fix for the
assembly
target, which should fail the target if a script-prepended assembly jar might be too big to be executable. Now, the strange thing is that the failing test is also about theassembly
target, but only on Windows (which I haven't access to). I think the Mill under test and the actual executing Mill versions shouldn't influence each other, but I have no other explanation for the failing test.