lefou
commented
1 month ago That BSP extension looks new to me, which surprises me, since I try to follow the BSP development closely. I think making a bespoken BSP extension without a proper specification the status quo (by supporting it in scala-cli and a major BSP client in the Scala world) is a worst case scenario and will render the whole BSP idea to nonsense. We should strive for getting this extension into the BSP spec. Therefore, please provide a link to the BSP issue, where this extension is discussed. If there is none, we should create one and link all existing implementations and discussions. Further discussion how the extension should behave should continue there (e.g. not in some discord channels). As it looks like, the extension is already developed, so all that is left is to formalize it in the spec and properly support it with a capability flag.
lolgab
scala-cli supports a bespoke extension to the the build server protocol. This extension allows the support of Scala scripts. Scala scripts are Scala code which is then wrapped at build time by some Scala code to make them valid Scala code. scala-cli-bsp's buildTarget/wrappedSources allows build tools to give the following information:
This PR adds Virtuslab's scala-cli-bsp library to the bsp worker module, and implements the handler for the buildTarget/wrappedSources call. To make the information available, it changes the return type of
generateScriptSourcesinMillBuildRootModuleto return, together with thePathRefof the destination folder, the four elements described above, so it can be used by BSP.