search

com-lihaoyi / mill

Your shiny new Java/Scala build tool!
https://mill-build.com/
MIT License
1.99k stars 303 forks source link

Support `build.sc` in Bloop #3208

Closed lolgab closed 2 weeks ago

lolgab commented 3 weeks ago

After Mill 0.11 mill-contrib-bloop stopped supporting the build module. Now BloopImpl gets a sequence of Evaluators and gets all modules for all the evaluators in Evaluator.allBootstrapEvaluators, so it supports the build module again.

Pull Request: https://github.com/com-lihaoyi/mill/pull/3208

lolgab commented 2 weeks ago

You are right! I was confusing the normal mill build with the meta-build. After Mill 0.11 mill-contrib-bloop stopped supporting the build module. This gets all modules for all the evaluators, so it supports the build module again. Maybe I should change the PR description since what I did is not specific to meta builds. What do you think?

lefou commented 2 weeks ago

You are right! I was confusing the normal mill build with the meta-build. After Mill 0.11 mill-contrib-bloop stopped supporting the build module. This gets all modules for all the evaluators, so it supports the build module again. Maybe I should change the PR description since what I did is not specific to meta builds. What do you think?

Yeah, makes sense. If you can move this message into a PR description, we should be good to merge it.

I assume full support for meta-builds should be around the corner, just by the fact that the bootstrap build works. What's needed for confidence is a test case with a meta-build. But this can be another PR.