search

com-lihaoyi / mill

Mill is a fast JVM build tool that supports Java and Scala. 2-3x faster than Gradle and 5-10x faster than Maven for common workflows, Mill aims to make your project’s build process performant, maintainable, and flexible
https://mill-build.org/
MIT License
2.04k stars 331 forks source link

Add Checkstyle plugin #3472

Closed m50d closed 3 weeks ago

m50d commented 1 month ago

(Commits not clean as I'm expecting to squash)

Fix: #3332

m50d commented 1 month ago

Build failures look like test infra flakiness/races (not finding the just-published module for the integration test, and a concurrent file opening error on Windows) rather than real issues?

lihaoyi commented 1 month ago

Will take a look. Our test suite is flaky, I've been working on it but not 100% stabilized yet

lihaoyi commented 1 month ago

Manually retries those jobs

lihaoyi commented 3 weeks ago

@m50d I'm going to go with https://github.com/com-lihaoyi/mill/pull/3516 as the implementation, but I'll pay out 30% of the bounty for the effort you put into this. Email me your bank transfer detail and I'll wire it over. Thanks for working through this with me, and this code has definitely been useful in helping me understand the solution and design space even though we may not end up merging it

m50d commented 1 week ago

Thank you - glad to have contributed something and agreed that that's ultimately the better approach.