search

com-lihaoyi / mill

Mill is a fast JVM build tool that supports Java and Scala. 2-4x faster than Gradle and 4-10x faster than Maven for common workflows, Mill aims to make your project’s build process performant, maintainable, and flexible
https://mill-build.org/
MIT License
2.22k stars 358 forks source link

Default KtlintModule to .editorconfig explicitly #3966

Closed myyk closed 1 week ago

myyk commented 1 week ago

For some reason ktlint behaves differently if it's config is set vs unset to it's default of .editorconfig.

It seems to be unable to disable ktlint when not explicitly set, so I think we should set it instead.

Why not bump the version while we're at it?

myyk commented 1 week ago

Sounds great. I'm offline now. Feel free to change it now or I'll handle it tomorrow when I'm up.

On Fri, Nov 15, 2024, 02:44 Li Haoyi @.***> wrote:

@.**** commented on this pull request.

In kotlinlib/src/mill/kotlinlib/ktlint/KtlintModule.scala https://github.com/com-lihaoyi/mill/pull/3966#discussion_r1842733113:

@@ -32,14 +32,14 @@ trait KtlintModule extends JavaModule {

  • Ktlint configuration file. */ def ktlintConfig: T[Option[PathRef]] = Task {
  • None
  • Some(PathRef(millSourcePath / ".editorconfig")) }

How about defaulting to Task.workspace / ".editorconfig"? I'd guess most folks would have the config file at the root of their project (which is what Task.workspace is) rather than in each module's subfolder

— Reply to this email directly, view it on GitHub https://github.com/com-lihaoyi/mill/pull/3966#pullrequestreview-2436938682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP4ANC66X4X73HRHAHDUEL2ATVRDAVCNFSM6AAAAABRZQHHNSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZWHEZTQNRYGI . You are receiving this because you authored the thread.Message ID: @.***>