Handle case of .mill-version with Windows line ends

com-lihaoyi / mill

Mill is a fast JVM build tool that supports Java and Scala. 2-4x faster than Gradle and 4-10x faster than Maven for common workflows, Mill aims to make your project’s build process performant, maintainable, and flexible

https://mill-build.org/

MIT License

2.22k stars 356 forks source link

Handle case of .mill-version with Windows line ends #3975

Closed sideeffffect closed 4 days ago

sideeffffect commented 6 days ago

This is a precaution for cases when the .mill-version file can contain a Windows line end \r\n instead of the typical Unix line end \n. Without this fix, in such situation the script breaks in a spectacular and surprising way.

The error it was giving looked like this:

$ mill __.compile
curl: (3) URL using bad/illegal format or missing URL

Where mill is pointing to the wrapper script that I'm changing in this PR

lihaoyi commented 6 days ago

Can you paste the error message you get when the issue this PR solves occurs into the PR description?

sideeffffect commented 4 days ago

done

lihaoyi commented 4 days ago

Thanks!