com-lihaoyi / mill

Mill is a fast JVM build tool that supports Java and Scala. 2-4x faster than Gradle and 4-10x faster than Maven for common workflows, Mill aims to make your project’s build process performant, maintainable, and flexible
https://mill-build.org/
MIT License
2.22k stars 358 forks source link

align SonatypeCentralPublishModule with SonatypePublisher #3987

Closed GeorgOfenbeck closed 6 days ago

GeorgOfenbeck commented 1 week ago

In the current version the SonatypeCentralPublishModule has non intented behaviour with PublishModule.defaultGpgArgs.

It will default to the args without a passphrase and afterwards ignore the passphrase env. var as a gpgarg is already set. To get the "correct" behaviour one has to override the args with an empty string to then pick up the "PGP_PASSPHRASE" env. arg.

Also changed the env. name to match the one from SonaTypePublisher "PGP_PASSPHRASE" -> "MILL_PGP_PASSPHRASE".

Currently pgp and gpg are getting used both in terms of naming - guessing going for gpg in the future might be more clear.

lihaoyi commented 6 days ago

Thanks!