com-lihaoyi / mill

Mill is a fast JVM build tool that supports Java and Scala. 2-4x faster than Gradle and 4-10x faster than Maven for common workflows, Mill aims to make your project’s build process performant, maintainable, and flexible

https://mill-build.org/

MIT License

2.22k stars 358 forks source link

Fixed: #3928 [Basic] Re-Work for First Class Python Support #4000

Open himanshumahajan138 opened 5 days ago

himanshumahajan138 commented 5 days ago

Pull Request

Added First Class Python Support [Basic Example] Fixes: #3928

Description

Rework for Python 1-simple, 2-custom-build-logic and 3-multi-module Examples follow up for PR #3992

Related Issues

Link to related issue #3928.

Checklist

[x] New Example for Python 1-Simple
[x] New Example for Python 2-custom-build-logic
[x] New Example for Python 3-multi-module
[x] Updated Documentation

Status

Completed Addition & Require Review!!!

himanshumahajan138 commented 4 days ago

@lihaoyi why //// SNIPPET:DEPENDENCIES or //// SNIPPET:TREE and more like this are not working for my python docs???

i was looking in other examples but there these are available and working how ?

Please Explain about this...

himanshumahajan138 commented 4 days ago

@lihaoyi Ready for Review!

lihaoyi commented 3 days ago

The issue with //// SNIPPET:DEPENDENCIES or //// SNIPPET:TREE were not working because this needs to be an ExampleCrossModuleJava which contains the template inheritance logic https://github.com/com-lihaoyi/mill/blob/b1f6be0c0c2817e8c623fac75c09e1a232c44b89/example/package.mill#L68.

Let's go back to using template inheritance and seeing how much of the example docs we can share; as we proceed through the rest of the Python example docs, I expect there will be large amounts of overlap between the docs and explanations, so we should get used to using the templated documentation to begin wtih

himanshumahajan138 commented 9 hours ago

@lihaoyi @jodersky Ready for Review Let's wrap it up!