com-lihaoyi / scalatags

ScalaTags is a small XML/HTML construction library for Scala.
https://com-lihaoyi.github.io/scalatags/
MIT License
753 stars 117 forks source link

Dependencies on deprecated scalajs-dom stuff #198

Open bwbecker opened 4 years ago

bwbecker commented 4 years ago

I'm using the latest version of scalatags on Maven (0.8.6). If I use the latest version of scalajs-dom (1.0.0) or even 0.9.8 I get a compile error:

[error] /Users/bwbecker/oat/src/oat3/modules/browser/src/main/scala/oat/browser/views/components/filteredTable/FilteredUsersTable.scala:123:7: Symbol 'type org.scalajs.dom.html.TableHeaderCell' is missing from the classpath.
[error] This symbol is required by 'lazy value scalatags.jsdom.Tags.th'.
[error] Make sure that type TableHeaderCell is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
[error] A full rebuild may help if 'Tags.class' was compiled against an incompatible version of org.scalajs.dom.html.
[error]       th("Userid"),
[error]       ^

The definition of th is

  lazy val th = typedTag[dom.html.TableHeaderCell]("th")

and in the Feb 7, 2020 commit of scalajs-dom in src/main/scala/org/scalajs/dom/html.scala we have the following code removed:

  @deprecated(
      "https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableHeaderCellElement",
      "0.9.8")
  type TableHeaderCell = raw.HTMLTableHeaderCellElement
ddworak commented 4 years ago

+1, this blocked the upgrade for us in udash-core https://github.com/UdashFramework/udash-core/pull/529

sake92 commented 3 years ago

Fixed in #201 ?