search

com-lihaoyi / scalatags

ScalaTags is a small XML/HTML construction library for Scala.
https://com-lihaoyi.github.io/scalatags/
MIT License
757 stars 117 forks source link

To scalajs-dom 1.0.0 #201

Closed mathieuleclaire closed 4 years ago

mathieuleclaire commented 4 years ago

The CI fails because of Phantomjs in mill. Similar errors occur in other PRs. @lihaoyi, is the next mill version will fix this ?

PhantomJS WS Jetty: INFO: jetty-8.1.16.v20140903 WrappedArray()

PhantomJS WS Jetty: INFO: Started {} WrappedArray(SelectChannelConnector@localhost:38887)

PhantomJS using webpage launcher at: /tmp/phantomjs-launcher-webpage932687803795478401.html

PhantomJS using launcher at: /tmp/phantomjs-launcher8404438365750764824.js

Starting process: phantomjs /tmp/phantomjs-launcher8404438365750764824.js

SyntaxError: Syntax error in /home/travis/build/lihaoyi/scalatags/out/scalatags/js/2.12.10/1.0.0/test/fastOptTest/dest/out.js

  phantomjs://code/phantomjs-launcher8404438365750764824.js:8 in onError

  phantomjs://code/phantomjs-launcher8404438365750764824.js:10 in onError

  file:///tmp/tmp-933054118150775815checkSyntaxError2.js:3 (in function "global code")

  phantomjs://code/phantomjs-launcher8404438365750764824.js:12

1 targets failed

scalatags.js[2.12.10,1.0.0].test.test org.scalajs.testing.common.RPCCore$ClosedException: org.scalajs.testing.adapter.JSEnvRPC$RunTerminatedException

org.scalajs.testing.adapter.JSEnvRPC$RunTerminatedException

org.scalajs.jsenv.ExternalJSRun$NonZeroExitException: exited with code 2

The command "./mill scalatags.js.__.test.test" exited with 1.
mathieuleclaire commented 4 years ago

Could you merge this (and release) so that scalatags is synchronized with scalajs-dom ?