search

com-lihaoyi / upickle

uPickle: a simple, fast, dependency-free JSON & Binary (MessagePack) serialization library for Scala
https://com-lihaoyi.github.io/upickle
MIT License
722 stars 165 forks source link

Allow string readers to handle numbers #521

Closed lihaoyi closed 1 year ago

lihaoyi commented 1 year ago

This was what we wanted all along - we added all th other visitInt* and visitFloat* overloads in https://github.com/com-lihaoyi/upickle/commit/f7b61ce42171d617996bc6ab3f2938019a51061b - but it was missing one overload that was necessary in the common parsing codepath

Fixes https://github.com/com-lihaoyi/upickle/issues/520

Covered by additional unit tests, and tweaked the json used in some failure tests to keep them failing