com-lihaoyi / upickle

uPickle: a simple, fast, dependency-free JSON & Binary (MessagePack) serialization library for Scala
https://com-lihaoyi.github.io/upickle
MIT License
722 stars 165 forks source link

Respect `Config#tagName` in `Reader.merge` and `ReadWriter.merge` #619

Closed mrdziuban closed 3 months ago

mrdziuban commented 3 months ago

Follow up to #579

The Reader.merge and ReadWriter.merge methods that don't take a tagKey param were retained for binary compatibility and updated to pass Annotator.defaultTagKey to the corresponding variant that does take a tagKey.

This updates them to instead respect Config#tagName, which defaults to Annotator.defaultTagKey but may be overridden by downstream users.

I also re-enabled mima checks and updated mimaPreviousVersions to just be 4.0.0, but I'm happy to back out those changes if they're not desirable.