com-pas / compas-open-scd

A substation configuration description editor for projects using SCL IEC 61850-6 Edition 2 or greater
https://openscd.github.io
Apache License 2.0
12 stars 3 forks source link

[Sitipe Plugin] - Connected AP's not imported correctly #296

Closed pascalwilbrink closed 5 months ago

pascalwilbrink commented 8 months ago

When adding a BayTypical to a Bay, the ConnectedAp's are not imported correctly. This is because the IED that has been added gets a new name. The ConnectedAp still points to the old IED name.

Logs

SITIPE Scl Import Logger - session start: 2023-11-17 16:39:19

2023-11-17 16:39:19 [Error] IedDevice::Init: Bay 'Vienna west'-'Europe_110kVViennawestA01' no ConnectedAP found for AccessPoint 'E' 2023-11-17 16:39:19 [INF] Topology::ReadIEDs: IED init Problem 'Europe_110kVViennawestA01' for parent 'Substation[Europe]/VoltageLevel[110kV]/Bay[Vienna west]' -> check! 2023-11-17 16:39:19 [Error] Topology::ReadIEDs: errors after IED init 'Substation[Europe]/VoltageLevel[110kV]/Bay[Vienna west]' 2023-11-17 16:39:19 [Error] ScdDocument::ReadIEDs: ReadIEDs failed for 'Substation[Europe]/VoltageLevel[110kV]/Bay[Vienna west]' 2023-11-17 16:39:19 [Error] SCDimportBL::StartImport: ReadIEDs error using SCD Path: 'C:\Users\al4056\Downloads\SITIPE-CoMPAS-demo\SYSCON_Europe_CV2-modifield2.scd' 2023-11-17 16:39:19 [INF] ExcelAddInFrame::StartImportFrmWorkbook4Scd: Log from Excel using AddIn: [StrBuf]: Wbk Start at 2023-11-17 16:39:19

Fix Change the IED Name after Importing that IED (https://github.com/com-pas/compas-open-scd/blob/main/packages/compas-open-scd/src/compas-editors/sitipe/sitipe-bay.ts#L570). Update the Communication -> ConnnectedAP so that the IEDName of connectedAP still points to the correct IED.

Acceptance criteria: Every reference to the new IED has an updated name

Sander3003 commented 6 months ago

Can is one be closed or are we waiting for an pull-request to finish?

Sander3003 commented 5 months ago

https://github.com/com-pas/compas-open-scd/pull/304