search

comakingspace / comakingspace.github.io

Check out the current state of the new website here:
https://comakingspace.github.io/
0 stars 0 forks source link

Swap Navigation item "Events" to "Calendar" #36

Closed Duehok closed 2 years ago

Duehok commented 2 years ago

If a website visitor wants to discover the Comaking space, they will want to see the usual opening hours. Those are described in the calendar, which is accessed by the navigation item Events. A visitor would expect "events" to describe special events (yearly meeting, special seminar, etc...), not usual activities. A calendar is expected to cover both.

Duehok commented 2 years ago

Will mark ready for review once I have tested the change

Duehok commented 2 years ago

I cannot test the site because the whole ruby+gem+jekyll+etc is a towering stack of shit that in typical FOSS fashion needs to be debugged before being used. I will not spend time for that. This should be tested before being merged.

NitramLegov commented 2 years ago

The change itself should work, but unfortunately there is a typo. I will therefore close the pull request and apply the proposed change myself accordingly.

Btw, there is a good documentation about how to test GitHub pages locally: https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/testing-your-github-pages-site-locally-with-jekyll

I never had any problems with using jekyll on my machines.

NitramLegov commented 2 years ago

Done. Additionally, I have changed the calendar view to preview the next 14 days (rolling)