search

combinaut / minibars

A (mostly) drop-in replacement for Handlebars.rb based on MiniRacer rather than therubyracer.
MIT License
8 stars 4 forks source link

Alias Handlebars::Context and Handlebars::SafeString unless defined #3

Closed delonnewman closed 2 years ago

delonnewman commented 2 years ago

Closes https://github.com/combinaut/minibars/issues/2

Should we alias Minibars::Template also? It doesn't seem necessary. But, what do you think?

njakobsen commented 2 years ago

I think it makes sense to alias that too since it's an analogue of the corresponding file in Handlebars.

delonnewman commented 2 years ago

I think it makes sense to alias that too since it's an analogue of the corresponding file in Handlebars.

The one concern I have is that the constructor doesn't conform to the same API. But, I think I agree with you.

njakobsen commented 2 years ago

Noting this for posterity: We decided to pull a 180 and not alias Handlebars::Template because it does not conform to the same API as the corresponding class in the Handlebars gem.