search

combine / universal-react-redux

šŸ§ A sensible universal starter kit for React + Redux
110 stars 18 forks source link

Why copy server path into dist folder ? #39

Closed xD3CODER closed 6 years ago

xD3CODER commented 6 years ago

I noticed that the command prod:build:server copy server folder into public dist folder. Server side code is therefore served by express in HTTP. Is it wanted or is it a mistake ?

image I suggest to build public files into dist/public and serve this directory with express rather than entiere dist directory

calvinl commented 6 years ago

Iā€™m not in front of a computer right now, but is dist served as static? If so, thatā€™s a mistake. Open to a PR if so, good catch!

xD3CODER commented 6 years ago

Fixed in #38