combust-labs / firebuild

Convenience of containers, security of virtual machines
https://combust-labs.github.io/firebuild-docs/
GNU Affero General Public License v3.0
97 stars 7 forks source link

Manually allocate the network interface #9

Closed radekg closed 3 years ago

radekg commented 3 years ago

Don’t rely on the SDK for interface allocation. This will allow passing the IP address / interface data into the VMM.

radekg commented 3 years ago

Mmmm, there is no need for that. https://github.com/firecracker-microvm/firecracker-go-sdk/blob/f88301ec41bb4f57b4af05f9abf2b35883b42a8f/handlers.go#L271 sets up the network as the first step in the process. That implies that my pseudo cloud init handler already has the IP address on the machine inherited from to chain.