search

combust / mleap

MLeap: Deploy ML Pipelines to Production
https://combust.github.io/mleap-docs/
Apache License 2.0
1.5k stars 310 forks source link

Fix MathBinary bug #830

Open WeichenXu123 opened 1 year ago

WeichenXu123 commented 1 year ago

Fix MathBinary bug

See https://github.com/combust/mleap/pull/824#discussion_r978030952

austinzh commented 1 year ago

Hi @WeichenXu123 Would you mind elaborate with more details? We are currently working on MathBinary, Maybe we can fix this in the sametime If we have more context.

WeichenXu123 commented 1 year ago

@austinzh You can see this line in my PR: https://github.com/combust/mleap/pull/824/files#r971927427

        # TODO: Deserialization on output_features has some issue. fix this.
        # assert_frame_equal(res_a, res_b)

If you enable this line assert_frame_equal(res_a, res_b), you will find the test failed, but it should pass. So this is a bug.