search

comcode-org / hackmud_chat_web

ajax web client for hackmud
Other
8 stars 9 forks source link

message scrollback #91

Closed seanmakesgames closed 5 years ago

seanmakesgames commented 5 years ago

on all channels / tells

hackmud-dtr commented 5 years ago

This requires working chat_history endpoint (see bug on forums); it isn't really viable to implement this without it.

forum bug report on chat_history: https://www.hackmud.com/forums/bugs_features_ideas/chat_api_chat_history_returns_empty_array_if_you_did_not_join_leave_the_specified_channel_between_the_specified_times

hackmud-dtr commented 5 years ago

What the chat history bug means in practice is that chat_history is almost never usable outside of a testing environment where you just recently joined a test channel. For users passively in 0000 for long periods of time (a common case), chat_history is useless.

seanmakesgames commented 5 years ago

yep. totes understood. we'll get it sorted.

hackmud-dtr commented 5 years ago

Also: i'm not 100% sure chat_history currently works on tells (if it does, the inability to ever join/leave tells might be masking it ;p)

seanmakesgames commented 5 years ago

fixed by https://github.com/DrizzlyBear/hackmud_chat_web/commit/e66bc2ce262959096de8a3deab77fa7449e8c109