search

comcode-org / hackmud_wiki

https://wiki.hackmud.com/
Other
13 stars 21 forks source link

Correct scripts.lib::dump documentation #384

Closed Fayti1703 closed 5 months ago

Fayti1703 commented 5 months ago

Problem

The documentation for scripts.lib's dump function is incorrect and misleading.

github-actions[bot] commented 5 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Fayti1703 commented 5 months ago

I have read the CLA Document and I hereby sign the CLA

We might need to set up some exclusions for ComCODE volunteers for this...

seanmakesgames commented 5 months ago

I have read the CLA Document and I hereby sign the CLA

We might need to set up some exclusions for ComCODE volunteers for this...

Needs to be exact I think. And I'm trying to figure out the right path for this. Managing the 'allowlist' per-repo-per-volunteer add is a lot of overhead

Fayti1703 commented 5 months ago

I have read the CLA Document and I hereby sign the CLA

Fayti1703 commented 5 months ago

recheck

seanmakesgames commented 5 months ago
Correct_scripts_lib__dump_documentation_by_Fayti1703_·_Pull_Request__384_·_comcode-org_hackmud_wiki

This is what happens when you use your own PAT for the bot. :P

Fayti1703 commented 5 months ago

By the way, do we want auto-locking on merge/close? I personally don't really see the use, and it prevents post-merge discussion on a PR.

seanmakesgames commented 5 months ago

By the way, do we want auto-locking on merge/close? I personally don't really see the use, and it prevents post-merge discussion on a PR.

people can erase their acceptance of the CLA--

I believe it only locks the thread in which a CLA was signed. --and only for non-collaborators

seanmakesgames commented 5 months ago

you can test