search

comcode-org / hackmud_wiki

https://wiki.hackmud.com/
Other
13 stars 21 forks source link

Rename 'Preprocessor Directives' -> 'JavaScript Extensions' #427

Closed Fayti1703 closed 3 months ago

Fayti1703 commented 3 months ago

Problem

Fixes #426

Problems with this change

~~This PR is currently marked as a draft because old direct links to pages under the renamed section fail with this PR applied. There are ways to set up redirects in Docusaurus, chiefly @docusaurus/plugin-client-redirects/; but that would be a significant dependency addition and I'm not sure how we want to handle that.~~

Currently considered "not an issue" (see discussion).

seanmakesgames commented 3 months ago

Do we think there are many direct links to these pages? Can we just break them and not worry about it?

Fayti1703 commented 3 months ago

There's a couple recent ones on Discord from @matr1x-hackmud; other those I doubt it.

Fayti1703 commented 3 months ago

Also is it just me or is the worker for the security/license issues check extremely slow for no apparent reason? It's been stuck trying to check out the repo for 20 minutes now (without even getting to the actual checkout!)

Stopped and re-ran the job; completed in 7s. What was that worker doin'.

seanmakesgames commented 3 months ago

There's a couple recent ones on Discord from @matr1x-hackmud; other those I doubt it.

I wouldn't worry about it then. @matr1x-hackmud can update his links if it matters, but people will find stuff even if links are broken.

Fayti1703 commented 3 months ago

I wouldn't worry about it then.

Alright, marking as ready for review.