Open tukib opened 11 months ago
This issue seems to be in good shape and ready to close, thoughts?
@kbinreallife I think so. A short description in CONTRIBUTING.md would suffice. How about this (below)? Last point replaces the current section on tests. we can leave the whole esm/cjs thing for #71.
Editing remark/rehype plugins or react components may require making changes to code.
.js
.mjs
.ts
.jsx
.tsx
)/src/plugins/remark/
for the first remark plugin, since we already have /src/plugins/rehype/
for rehype plugins.foo.js
and bar.ts
should have tests foo.test.js
and bar.test.ts
Problem
Both JavaScript and TypeScript exist and can be used in our project. We have no policy to inform contributors whether they can check in both files, or if we require JS-only or TS-only.
Context
For now, I propose we allow both. Our contributors have mixed preferences, so this is where we currently stand. No configuration changes need to be pushed for this.
this depends on