search

comeara / pillar

Pillar manages migrations for your Cassandra data stores.
https://github.com/comeara/pillar
MIT License
111 stars 64 forks source link

Shutdown cluster in migrate & initialize #5

Closed magro closed 10 years ago

magro commented 10 years ago

This should be done to release resources, which is relevant when used in a running application (e.g. Play).

Another great thing to accept an existing session in CassandraMigrator, so that the application using it could just pass the session its creating anyways. I didn't do this because migrate/initialize right now accept a DataStore which would then be obsolete, at least it's not straight forward to allow both - probably there would be 2 constructors: 1 accepting a DataStore and another one accepting a session.

pvenable commented 10 years ago

This doesn't compile now that we're on 2.0.1. It looks like shutdown may have been replaced with close.

magro commented 10 years ago

@pvenable You're right, I just added a commit to fix that. Can you push a new release to maven central / when could you do this?

pvenable commented 10 years ago

Thanks.

I'm looking to push a new release as soon as possible.